Made changes requested at code review - Githubissues

newrelic / nri-jmx

New Relic Infrastructure JMX Integration

Apache License 2.0

6 stars 16 forks source link

Made changes requested at code review #5

Closed camdencheek closed 6 years ago

camdencheek commented 6 years ago

Description of the changes

Made changes requested in code review. Lower cased error messages. Added comments. Collected errors as an array. Simplified some code.

PR Review Checklist

Author

[ ] add a risk label after carefully considering the "blast radius" of your changes
[ ] describe the intent of your changes in the description. don't just rewrite your code in prose
[ ] assign at least one reviewer

Reviewer

[ ] review code for readability
[ ] verify that high risk behavior changes are well tested
[ ] check license for any new external dependency
[ ] ask questions about anything that isn't clear and obvious
[ ] approve the PR when you consider it's good to merge