Bean patter error displays correct pattern - Githubissues

newrelic / nri-jmx

New Relic Infrastructure JMX Integration

Apache License 2.0

6 stars 16 forks source link

Bean patter error displays correct pattern #52

Closed varas closed 4 years ago

varas commented 4 years ago

Description of the changes

An MBean pattern error now displays the correct pattern.

Msg displayed before:

[ERR] Failed to complete collection: cannot parse bean pattern: *:

Msg displayed now:

[ERR] Failed to complete collection: cannot parse MBean glob pattern, valid: 'DOMAIN:BEAN', your pattern: *:

PR Review Checklist

Author

[ ] the PR should focus on a single subject. Change only relevant files to the problem you’re working on Clean and format the code
[ ] add unit tests for your changes and make sure all unit tests are passing
[ ] add a risk label after carefully considering the "blast radius" of your changes
[ ] describe the intent of your changes in the description. don't just rewrite your code in prose
[ ] assign at least one reviewer
[ ] address the feedback

Reviewer

[ ] review code for readability
[ ] verify that high risk behavior changes are well tested
[ ] check license for any new external dependency
[ ] ask questions about anything that isn't clear and obvious
[ ] approve the PR when you consider it's good to merge