newrelic / nri-kubernetes

New Relic integration for Kubernetes
https://docs.newrelic.com/docs/integrations/kubernetes-integration/get-started/introduction-kubernetes-integration
Apache License 2.0
40 stars 51 forks source link

Add quotes to "true" value so it is not interpreted as a boolean #1044

Closed maxlemieux closed 3 weeks ago

maxlemieux commented 1 month ago

Description

The scrape label for namespaces is documented in values with a commented example. This example will not run as-is and results in the newrelic-infrastructure pods crashing on startup.

newrelic.com/scrape: true

This change adds quotes (") to the example. Tested working on a fresh installation.

newrelic.com/scrape: "true"

Type of change

Checklist:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.15%. Comparing base (3934c83) to head (065c6c4).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1044 +/- ## ======================================= Coverage 70.15% 70.15% ======================================= Files 46 46 Lines 3113 3113 ======================================= Hits 2184 2184 Misses 762 762 Partials 167 167 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

celerity12 commented 1 month ago

Hi Max, Do we have a timeline for this PR to be merged into the branch. Please let us know. Thanks Sumit