[NR-254437] fix: use int64 instead of int for numeric values from queries

newrelic / nri-mssql

New Relic Infrastructure Mssql Integration

MIT License

8 stars 18 forks source link

[NR-254437] fix: use int64 instead of int for numeric values from queries #162

Closed sigilioso closed 2 months ago

sigilioso commented 2 months ago

Fixes #153

int64 (instead of int) is used to represent numeric values coming from queries. API limits are respected and int64 is already used in other sdk-based integrations (example)

marcsanmi commented 2 months ago

Would adding a simple test to avoid breaking this again in the future make sense? 🤔

sigilioso commented 2 months ago

Would adding a simple test to avoid breaking this again in the future make sense? 🤔

It would, actually I started with a tests. But, since int can be either 32 or 64, reproducing it is not trivial (we would need some arch-dependent tests) and I don't think it is worth it.