added support for custom eventtype - Githubissues

newrelic / nri-nagios

New Relic Infrastructure Nagios Integration

MIT License

3 stars 13 forks source link

added support for custom eventtype #18

Closed ghost closed 4 years ago

ghost commented 5 years ago

Description of the changes

Added support for custom eventtype; now nagios events can be listed under different tables in insights.

PR Review Checklist

Author

[ ] add a risk label after carefully considering the "blast radius" of your changes
[x] describe the intent of your changes in the description. don't just rewrite your code in prose
[ ] assign at least one reviewer

Reviewer

[ ] review code for readability
[ ] verify that high risk behavior changes are well tested
[ ] check license for any new external dependency
[ ] ask questions about anything that isn't clear and obvious
[ ] approve the PR when you consider it's good to merge

camdencheek commented 4 years ago

Thank you for the pull request. However, I don't think we will be able to merge this because we try to keep the event types standard to avoid confusion and to facilitate automatic dashboard creation.

If there is a specific reason you want to be able to customize the table names, please let us know and we'll see if we can make improvements for that use case in a future version