Closed jeffdesc closed 4 years ago
Hi @jeffdesc -- Thanks for the PR. I'll take a look over this sometime today
Looks great. I'll get this released in the next couple of days
Hey @camdencheek, thanks for the feedback. Any idea when this will be released? We're stuck at the moment and awaiting this release to proceed.
@jeffdesc Whoops -- thought I had included it in the last release. I'll go ahead and make a release right now. Sorry about that!
No problem @camdencheek, thank you very much!
Description of the changes
All results of all service checks are being added to the "NagiosServiceCheckSample", but in most situations you want to split this up to have custom samples per service check. This way you can structure your data in New Relic Insights properly.
This code is in use in a forked version in our monitoring system and has been tested, it's been working as expected.
However on every major code change, I've to re-create a patch which creates too much hassle. This way it can be pushed into the NRI Nagios code base.
PR Review Checklist
Author
Reviewer