search

newrelic / nri-perfmon

Windows Perfmon / WMI On-Host Integration for New Relic Infrastructure
Other
13 stars 19 forks source link

ASP.NET counter from PerfMon provider isn't reported #18

Closed brunotag closed 4 years ago

brunotag commented 4 years ago

We noticed the "ASP.NET" counter from the PerfMon provider isn't reported.

Example config:

{
  "counterlist": [
       {
      "provider": "PerfCounter",
      "category": "ASP.NET",
      "instance": "*",
      "counters": [
        { "counter": "*" }
      ]
    }
  ]
}

We think this happens because the ASP.NET counter legitimately doesn't have instances, but currently the code doesn't allow for that.

That could be easily fixed with a little code change (we've tested this on our environment, Windows Server 2012 R2 64bit).

See: https://github.com/newrelic/nri-perfmon/pull/17

sschwartzman commented 4 years ago

Merged! Thanks @brunotag!

New release with your PR included: https://github.com/newrelic/nri-perfmon/releases/tag/0.5.1