newrelic / nri-perfmon

Windows Perfmon / WMI On-Host Integration for New Relic Infrastructure
Other
13 stars 19 forks source link

Eventlog messages all have EventId zero #27

Closed rpresser closed 3 years ago

rpresser commented 3 years ago

Example:

Warning 12/2/2020 3:11:52 PM    nri-perfmon 0   None
Error   12/2/2020 3:11:52 PM    nri-perfmon 0   None
Warning 12/2/2020 3:11:52 PM    nri-perfmon 0   None
Error   12/2/2020 3:11:52 PM    nri-perfmon 0   None

Assigning some event IDs could be helpful

sschwartzman commented 3 years ago

What should the eventId correspond to?

rpresser commented 3 years ago

It's application-specific, so I guess the way to start is to collect some typical messages and see if they fall into common categories, then assign numbers there.

sschwartzman commented 3 years ago

Ah, I see. I'd say if you have any suggestions then we can work them in (or you can PR back to the repo to do this) but otherwise I'm going to leave this one be. The message text is the useful part, categorically there aren't many different types of errors experienced by this plugin.