search

newrelic / nri-varnish

New Relic Varnish Integration
MIT License
3 stars 10 forks source link

Allow varnish_name option #33

Closed deancouch closed 3 years ago

deancouch commented 3 years ago

Allows us to pass the varnish instance name as an argument to varnishstats re https://github.com/newrelic/nri-varnish/issues/32 The use case is for when we are running varnish with the -n option, eg varnishd -n my_varnish_name Option is added to the config file, under arguments.

...
      instance_name: <User defined name to identify data from this instance in New Relic>
      varnish_name: <Optional. Specify the varnishd working directory (see varnishd -n)>
...

If omitted, varnishstats will continue to use the default varnish instance.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

gsanchezgavier commented 3 years ago

Hi @deancouch , many thanks for your contribution! do you mind if I jump to your branch to rebase + adding some integration tests ?

deancouch commented 3 years ago

@gsanchezgavier @paologallinaharbur - thanks for merging this, and adding the tests / cleanup 👍