newrelic / nri-winservices

Windows services Integration for New Relic Infrastructure

Apache License 2.0

8 stars 8 forks source link

fix to use entity registration #46

Closed gsanchezgavier closed 3 years ago

gsanchezgavier commented 3 years ago

Description

Use the new entity type WIN_SERVICE
Removes Inventory workarround for metadata
Renames metrics to snake_case format
Removes windowsService.entityName metadata used as workaround to filter charts. This field is aggregated by the backend

Fixes #45

Checklist:

[x] I checked that Licenses of new dependencies is compliant with our guidelines
[x] I have performed a self-review of my own code
[x] I have added comments in my code to clarify it
[x] I have updated the documentation accordingly
[x] I have added tests that show my fix/feature works
[ ] I cleaned the commit history, and they are following the conventional commits pattern, es:

type(scope): what I have changed

paologallinaharbur commented 3 years ago

Can you fix conflicts rebasing?