newrelic / open-source-office

Planning repo for New Relic open source office.
Apache License 2.0
0 stars 7 forks source link

Layout nerdpacks: Explicitly set the height on all sections so that the `fullHeight` prop of charts works with out extra configuration #27

Open danielgolden opened 4 years ago

danielgolden commented 4 years ago

In some sections of the nerdpacks, when you add fullHeight to a chart, it disappears (because charts with that prop need a parent with a defined width). Not our fault, but we can help reduce the friction of having to figure that out by just defining a height on all sections by default. I think setting them all to height: 100% should do it.