newrelic / opensource-website

Source code for New Relic's Opensource site.
https://opensource.newrelic.com
Apache License 2.0
145 stars 93 forks source link

Clark/cls troubleshooting #1016

Closed clarkmcadoo closed 11 months ago

clarkmcadoo commented 11 months ago

Updates the PageHeader component to no longer use a Higher Order Component during its rendering, this was causing it to render last during page load and was potentially causing a high CLS. I was only able to test this via a local build in the React Profiler, so this PR will test that theory on a Gatsby Cloud build.

gatsby-cloud[bot] commented 11 months ago

:white_check_mark: opensource-website-develop deploy preview ready

clarkmcadoo commented 11 months ago

Everything seems to load ok at https://build-ae2c690a-675d-47e5-94c1-ea7ac4cc0403.gatsbyjs.io/projects/newrelic/opentelemetry-exporter-go in the Performance tool

roadlittledawn commented 11 months ago

nice!

just checked out couple pages:

ran performance report. no layout shift reported. let's see what it does in the wild

nr-opensource-bot commented 11 months ago

:tada: This PR is included in version 1.24.10 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: