search

newrelic / opensource-website

Source code for New Relic's Opensource site.
https://opensource.newrelic.com
Apache License 2.0
153 stars 91 forks source link

Nerdpack layout .json files need icons specified #422

Closed danielgolden closed 4 years ago

danielgolden commented 4 years ago

Description

For example, the project page standard layout nerdpack (and probably all of those layout nerdpacks) has an launcher icon but it's not displayed at the top of the page (instead the placeholder icon is displayed).

Steps to Reproduce

View any of the layout nerdpack project pages.

Expected Behaviour

That the launcher icons for these projects would be displayed on the project page or in search results.

Relevant Console output

Your Environment

tangollama commented 4 years ago

@danielgolden that's not a bug. The iconUrl is null. You need to set that value to the path to the icon. For instance: https://github.com/newrelic/nr1-observability-maps/blob/master/icon.png?raw=true in https://github.com/newrelic/opensource-website/blob/develop/src/data/projects/newrelic-nr1-observability-maps.json

danielgolden commented 4 years ago

ooohh, Ok. I'll do that 👍

nr-opensource-bot commented 4 years ago

:tada: This issue has been resolved in version 0.5.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: