newrelic / opensource-website

Source code for New Relic's Opensource site.
https://opensource.newrelic.com
Apache License 2.0
155 stars 89 forks source link

[OSS] Add gatsby-build-newrelic plugin to OSS site #882

Closed jpvajda closed 2 years ago

jpvajda commented 2 years ago

Related Bug: https://github.com/newrelic-experimental/gatsby-build-newrelic/issues/24

Following the instructions here, add the gatsby-build-newrelic plugin to the OSS site an install the quckstart for gatsby build for so we can measure the OSS sites build times more effectively.

Acceptance Criteria

jpvajda commented 2 years ago

This ticket lead to some documentation updates in the plugin repo which @rudouglas did, and we found a bug: newrelic-experimental/gatsby-build-newrelic#24.

question: @rudouglas should we resolve this bug before I put this change on the develop branch? It seems it's just impacted the metrics dashboards, but I wanted to check before I proceed.

rudouglas commented 2 years ago

Ye lets hold off until we can get the metrics reporting @jpvajda

rudouglas commented 2 years ago

This is fixed now @jpvajda just remember we need the Environment variables in develop and main if we're going to merge the PR

jpvajda commented 2 years ago

@rudouglas you just made my list of ACs 🤣

jpvajda commented 2 years ago

Re-opening as the merge from develop to main failed a check

https://github.com/newrelic/opensource-website/pull/888

jpvajda commented 2 years ago

dashboard can be found here.