newrelic / opensource-website

Source code for New Relic's Opensource site.
https://opensource.newrelic.com
Apache License 2.0
155 stars 89 forks source link

feat: added gatsby-build-newrelic #883

Closed jpvajda closed 2 years ago

jpvajda commented 2 years ago

This PR adds configuration to run gatsby-build-newrelic on the OSS Site

gatsby-cloud[bot] commented 2 years ago

Gatsby Cloud Build Report

opensource-website-develop

:tada: Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

:clock1: Build time: 3m

Performance

Lighthouse report

Metric Score
Performance :large_orange_diamond: 31
Accessibility :large_orange_diamond: 88
Best Practices :green_heart: 93
SEO :large_orange_diamond: 85

:link: View full report

rudouglas commented 2 years ago

@jpvajda doing some testing here with branch versions of the plugin

rudouglas commented 2 years ago

I got this working again @jpvajda don't forget to add the Environment Variables to develop and main in Gatsby Cloud before

jpvajda commented 2 years ago

@rudouglas not sure why this is failing again? I added the env variables to develop and main site branches...

jpvajda commented 2 years ago

All the builds are failing again, so I'm going to remove the env variables from Main / Develop as I don't want to block a build from succeeding.

jpvajda commented 2 years ago

Actually all I had to do was remove the variable for

GATSBY_OPEN_TRACING_CONFIG_FILE="node_modules/gatsby-build-newrelic/zipkin-local.js"

And it builds fine on gatsby cloud but this PR is still failing the build 🤷

Screen Shot 2021-11-19 at 3 51 21 PM
rudouglas commented 2 years ago

@jpvajda i noticed another issue with the plugin which is fixed now so this is building good now

nr-opensource-bot commented 2 years ago

:tada: This PR is included in version 1.19.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: