search

newrelic / opentelemetry-exporter-go

New Relic's Golang OpenTelemetry Exporter
Apache License 2.0
29 stars 28 forks source link

Update span.go #31

Closed MrAlias closed 3 years ago

MrAlias commented 3 years ago

Span kinds are lowercase internal to New Relic. Avoid the downstream conversion by sending the correct format here.

justinfoote commented 3 years ago

Should all of our OpenTelemetry exporters convert span.kind to lower case? And should we do that for any other attributes?

MrAlias commented 3 years ago

Should all of our OpenTelemetry exporters convert span.kind to lower case? And should we do that for any other attributes?

Possibly. I would probably want to double check I am indeed correct on this assumption before we prescribe it for all.