search

newrelic / puppet-nrsysmond

Puppet module to install the New Relic Server Monitor
MIT License
8 stars 19 forks source link

rake, spec and CentOS 7 fixes #6

Closed jantman closed 9 years ago

jantman commented 9 years ago

(1) Fix a number of Rake and spec issues so the tests actually work.

(2) Per https://support.newrelic.com/requests/130089, have Puppet manage the group and user on RedHat 7. This is because of a broken useradd command in the RPM that fails on distros using shadow-utils >= 4.1.5. I strongly disagree with fixing a broken RPM in a Puppet module, but this is what Support told me to do.

On a side note: (1) This module is way out of date in terms of Puppet module standards. It uses a number of deprecated patterns and the spec tests are woefully incomplete. When Puppet4 comes out (which is going to be soon), this module will no longer be functional. (2) There are a number of places for improvement, such as the exec used to install the Yum repository, when there's a native type for this.

jantman commented 9 years ago

This fixes the CentOS7 issue for me.

jessedearing commented 9 years ago

Thanks for the PR and the help getting this module into shape.

We'll look at getting it ready for Puppet 4 at some point.

jantman commented 9 years ago

@jessedearing ok, I've switched that conditional from RedHat 7+ to SELinux and updated the specs.

I haven't switched over to Puppet4 yet, but I might have some bandwidth to assist with this module when we started rolling Puppet4 out in our test environments.

jantman commented 9 years ago

@jessedearing in our support ticket, I was told a fix for the RPM issue should be coming soon and this won't be merged. Would you like me to cut a separate PR that removes the SELinux/CentOS7 stuff, and just has the rspec and puppet-lint fixes?

jessedearing commented 9 years ago

@jantman That would be great!

jantman commented 9 years ago

Closing in favor of #7 which has the rakefile/testing/spec fixes but none of the CentOS7/SELinux stuff.