newrelic / repolinter-action

✅Run Repolinter in your CI pipeline
Apache License 2.0
8 stars 18 forks source link

Create a standard ruleset for New Relic One Catalog projects #2

Closed tangollama closed 4 years ago

tangollama commented 4 years ago

See this link for details: https://opensource.newrelic.com/oss-category/#new-relic-one-catalog-project

Follow up questions:

cc: @melissaklein24 @jbeveland27

jbeveland27 commented 4 years ago

@tangollama If this is specific to Catalog projects, should this ruleset contain all of the checks validate-nerdpack-action does? The validate action will run when PR'ing into the Catalog, but this could establish all of those files/commands being present before we get to that point (or we could just run validate-nerdpack-action in the Nerdpack repos 🤷 ).

Mainly wondering, do we want this action and ruleset to supersede the validate-nerdpack-action?

tangollama commented 4 years ago

More than anything, this is a PoC for the repolinter-action. Totally agree that these rules need to encompass the validate-nerdpack-action. I'll review and (try) to reconcile accordingly.

prototypicalpro commented 4 years ago

Here is my first draft of the NR1 config: https://github.com/aperture-science-incorporated/.github/blob/7a363c948c7f4293d559d92ae908f763a3ad3148/repolinter-newrelic-nr1catalog.json. An example issue this configuration generates is here: https://github.com/aperture-science-incorporated/cores/issues/19.