search

newrelic / rusty-hog

A suite of secret scanners built in Rust for performance. Based on TruffleHog (https://github.com/dxa4481/truffleHog) which is written in Python.
Apache License 2.0
452 stars 59 forks source link

Update dependencies #47

Open cutler-scott-newrelic opened 2 years ago

cutler-scott-newrelic commented 2 years ago

Summary

A lot of the dependencies are now majorly out of date, but simply changing the cargo.toml is not enough, a fair amount of code will need to be re-written to support the newer libraries.

Additional context

Updating libraries will support newer features and hopefully improve performance.

Coruscant11 commented 1 year ago

Hello, I would like to work on this issue. It will be my first time contributing to open source project, do you have any advice? I will make a commit per dependency update, is it a good way?

I am using rusty hog at work (I am a computer science student and apprentice at Amadeus), I like it and want to help.

I would be happy to try to update it to gitoxide too, but I will try this issue first. I forked the repo and I started to work on this issue and I will keep you updated. Feel free to share any advice! Thanks

cutler-scott-newrelic commented 1 year ago

Hi Coruscant, thanks for the offer! I would definitely recommend to start with one package at a time, and avoid a few of the more problematic packages by focusing on the best maintained ones like Clap

cutler-scott-newrelic commented 1 year ago

Also, avoiding the packages that are actually making network calls will probably help keep things simple

Coruscant11 commented 1 year ago

Okay! I will try to start with clap then. Thanks