Closed pranav-new-relic closed 6 months ago
Attention: Patch coverage is 0%
with 13 lines
in your changes are missing coverage. Please review.
Project coverage is 33.78%. Comparing base (
e6a5d8e
) to head (43214e8
).
Files | Patch % | Lines |
---|---|---|
newrelic/data_source_newrelic_entity.go | 0.00% | 13 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
New Relic Internal
Jira
Summary
This PR proposes the addition of a new attribute
ignore_not_found
to thenewrelic_entity
data source in order to "ignore" not found errors if settrue
in the configuration, thereby stopping automated Terraform pipelines from halting if the entity is lost, which is useful in cases when the entity abruptly expires (see original usecase proposed by the customer in #2599).Testing
The changes have been manually verified multifold. The test cases could not be updated because they fail with an
"id" not found error
, since the data source fetches no entity, which we try validating (without the expectation of an error being thrown, instead).