newrelic / terraform-provider-newrelic

Terraform provider for New Relic
https://registry.terraform.io/providers/newrelic/newrelic/latest/docs
Mozilla Public License 2.0
202 stars 245 forks source link

feat: Support Host Not Reporting as NRQL conditions #2630

Closed baNROne closed 5 months ago

baNROne commented 6 months ago

Description

Add support for configuring Host Not Reporting conditions as NRQL conditions. https://new-relic.atlassian.net/browse/NR-232401

NRQL Alert conditions will be receiving a new feature. Users will be able to use NRQL alert conditions to notify when New Relic stopped receiving data from an infrastructure agent.

The boolean on the expiration field will not trigger alerts for hosts that perform a clean shutdown option

This PR adds the boolean infra_host_clean_shutdown to the newrelic_nrql_alert_condition resource. By default it is set to false at our API level.

Please do not merge until merging this change for the Go client: https://github.com/newrelic/newrelic-client-go/pull/1111

Type of change

Please delete options that are not relevant.

Checklist:

Please delete options that are not relevant.

CLAassistant commented 6 months ago

CLA assistant check
All committers have signed the CLA.

pranav-new-relic commented 6 months ago

Thank you for the code addition, @baNROne :)

Please do not merge until merging this change for the Go client: https://github.com/newrelic/newrelic-client-go/pull/1111

acknowledged 👍

baNROne commented 5 months ago

We're reevaluating our approach to this project. Closing this out for now.