newrelic / terraform-provider-newrelic

Terraform provider for New Relic
https://registry.terraform.io/providers/newrelic/newrelic/latest/docs
Mozilla Public License 2.0
202 stars 245 forks source link

fix: Handle monitorID error not found #2640

Closed abasha1234 closed 5 months ago

abasha1234 commented 5 months ago

Description

This PR includes changes for throwing an error as invalid monitor ID when an invalid monitor ID is provided for the resource newrelic_synthetics_multilocation_alert_condition.

Ticket : https://new-relic.atlassian.net/browse/NR-257490

Fixes # (issue) Issue: https://github.com/newrelic/terraform-provider-newrelic/issues/2631

Checklist:

Please delete options that are not relevant.

pranav-new-relic commented 5 months ago

@abasha1234 the changes good look to me. Can you please also add a test case (with an invalid monitor ID in the entities field) and validate the error being thrown?