newrelic / terraform-provider-newrelic

Terraform provider for New Relic

https://registry.terraform.io/providers/newrelic/newrelic/latest/docs

Mozilla Public License 2.0

202 stars 245 forks source link

docs(cloud-integration): Fix documentation defects cloud integration resources #2649

Closed abasha1234 closed 4 months ago

abasha1234 commented 5 months ago

Description

This PR will enhance the documentation of all of the cloud integration resources by placing realistic values of metric polling intervals.

JIRA: NR-262902

Metric polling interval values for the resources located in newrelic-terraform docs has been updated referencing UI and NR docs

Checklist:

Please delete options that are not relevant.

[x] My commit message follows conventional commits
[x] My code is formatted to Go standards
[x] I have performed a self-review of my own code
[x] I have made corresponding changes to the documentation

pranav-new-relic commented 4 months ago

@abasha1234 thanks for all of this amazing work. I have some final feedback that I've shared via a set of comments - please sync your branch with main, and have them addressed - once done, we should be good to merge 👍

abasha1234 commented 4 months ago

Thanks for the feedback @pranav-new-relic updated the document and resolve the conversation

pranav-new-relic commented 4 months ago

@abasha1234 please apply this comment https://github.com/newrelic/terraform-provider-newrelic/pull/2649/files#r1595089936 to all relevant places where ranges of metrics polling intervals have been mentioned

pranav-new-relic commented 4 months ago

@abasha1234 everything else looks good to me, please only address this one and we should be good. https://github.com/newrelic/terraform-provider-newrelic/pull/2649#issuecomment-2102133613

By the way, a question - are we sure that the minimum metrics polling interval of all GCP integrations is 300 seconds? Would just like to double check with you, since we don't seem to have categories of multiple minimum metrics polling interval values in the GCP changes you've made, unlike the case with AWS and Azure

abasha1234 commented 4 months ago

@abasha1234 everything else looks good to me, please only address this one and we should be good. #2649 (comment)

By the way, a question - are we sure that the minimum metrics polling interval of all GCP integrations is 300 seconds? Would just like to double check with you, since we don't seem to have categories of multiple minimum metrics polling interval values in the GCP changes you've made, unlike the case with AWS and Azure

Yes, as per the docs provided by New Relic the minimum metrics_polling_interval for GCP integrations is 300 seconds. Please head over to this documentation as proof.

pranav-new-relic commented 4 months ago

Looks good to me 👍