newrelic / terraform-provider-newrelic

Terraform provider for New Relic
https://registry.terraform.io/providers/newrelic/newrelic/latest/docs
Mozilla Public License 2.0
200 stars 244 forks source link

feat(nrql_alert_condition): Add support for data account ID #2706

Closed founddrama closed 3 days ago

founddrama commented 4 days ago

Description

Type of change

Checklist:

How to test this change?

codecov-commenter commented 3 days ago

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 37.09%. Comparing base (92361de) to head (0eda853). Report is 43 commits behind head on main.

Files Patch % Lines
...wrelic/structures_newrelic_nrql_alert_condition.go 62.50% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2706 +/- ## ========================================== + Coverage 32.82% 37.09% +4.27% ========================================== Files 98 98 Lines 26884 21948 -4936 ========================================== - Hits 8824 8142 -682 + Misses 17902 13645 -4257 - Partials 158 161 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pranav-new-relic commented 3 days ago

performing some final checks before merge ....

pranav-new-relic commented 3 days ago

(performing final checks on main. Will push for a release once checked in the next hour)