Closed founddrama closed 3 days ago
Attention: Patch coverage is 78.57143%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 37.09%. Comparing base (
92361de
) to head (0eda853
). Report is 43 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...wrelic/structures_newrelic_nrql_alert_condition.go | 62.50% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
performing some final checks before merge ....
(performing final checks on main
. Will push for a release once checked in the next hour)
Description
data_account_id
field on NRQL alert conditions which allows accounts to add NRQL alert conditions that look at a signal from data reporting to another account IDType of change
Checklist:
How to test this change?
nrql_alert_condition
with adata_account_id
-- thedata_account_id
may be the same account ID as the alert condition, or it may be an account ID that is in the same organization (the condition should create successfully)nrql_alert_condition
to have adata_account_id
-- given anrql_alert_condition
created without adata_account_id
, add one; given anrql_alert_condition
created with adata_account_id
, change it (the condition should update successfully)nrql_alert_condition
without adata_account_id
-- it's an optional field, so you should be able to create a condition "the old fashioned way" (i.e., without specifying one -- it'll just inherit the account ID that is otherwise used to create the condition)