newrelic / terraform-provider-newrelic

Terraform provider for New Relic

https://registry.terraform.io/providers/newrelic/newrelic/latest/docs

Mozilla Public License 2.0

200 stars 244 forks source link

docs: fix dashboard threshold #2709

Closed smcavallo closed 2 days ago

smcavallo commented 3 days ago

Signed-off-by: smcavallo smcavallo@hotmail.com

Description

fixes dashboard threshold documentation. The current values (if used) generate an exception:

Attribute must be a whole number, got 0.5
Attribute must be a whole number, got 0.75

These must be TypeInt https://github.com/newrelic/terraform-provider-newrelic/blob/main/newrelic/resource_newrelic_one_dashboard.go#L600-L610

Fixes # (issue)

Type of change

Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[X ] This change requires a documentation update

Checklist:

Please delete options that are not relevant.

[X ] My commit message follows conventional commits
[ ] My code is formatted to Go standards
[X ] I have performed a self-review of my own code
[X ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes. Go here for instructions on running tests locally.

How to test this change?

Please describe how to test your changes. Include any relevant steps in the UI, HCL file(s), commands, etc

Step 1
Step 2
etc

pranav-new-relic commented 2 days ago

thank you @smcavallo :)