newrelic / terraform-provider-newrelic

Terraform provider for New Relic
https://registry.terraform.io/providers/newrelic/newrelic/latest/docs
Mozilla Public License 2.0
202 stars 245 forks source link

chore(modules): add a new module for golden signal alerts based on newrelic_nrql_alert_condition #2715

Closed shashank-reddy-nr closed 2 months ago

shashank-reddy-nr commented 2 months ago

Description

As the GitHub issue states https://github.com/newrelic/terraform-provider-newrelic/issues/2686, the current module we have for golden signal alerts in the Terraform Provider’s repository is obsolete, as it comprises references to legacy alert conditions which are now deprecated. Hence, the ask is to have references of legacy alert conditions in the module moved to newrelic_nrql_alert_condition.

Type of change

Please delete options that are not relevant.

Checklist:

Please delete options that are not relevant.

pranav-new-relic commented 2 months ago

@shashank-reddy-nr please also run a terraform fmt on both of these modules which would help format Terraform configuration in all *.tf files

pranav-new-relic commented 2 months ago

@shashank-reddy-nr let's call the module golden-signal-alerts-new and not new-golden-signal-alerts