nrEventProcessor() safety checks

newrelic / video-agent-roku

New Relic Agent for Roku

Apache License 2.0

18 stars 18 forks source link

nrEventProcessor() safety checks #11

Closed timalacey closed 4 years ago

timalacey commented 4 years ago

We're seeing a few crashes on line 36

CLAassistant commented 4 years ago

All committers have signed the CLA.

asllop commented 4 years ago

Is it an actual bug of the agent or is it app related? Could you provide a testing case to reproduce the issue?

timalacey commented 4 years ago

We haven't been able to reproduce it, but it has made appearances in crash logs from Roku, which aren't detailed.

asllop commented 4 years ago

Thanks for your report, I just wanted to understand how the m.nr can be undefined inside the nrEventProcessor function. Right before it is called we ensure it contains a valid reference to NRAgent:

I'm accepting your PR.