search

newrelic / video-agent-roku

New Relic Agent for Roku
Apache License 2.0
18 stars 18 forks source link

Video instance reference is kept in the agent and cannot be destroyed #20

Closed bchelkowski closed 3 years ago

bchelkowski commented 3 years ago

After using NewRelicVideoStart the video node reference is saved in the scope of the new relic agent. https://github.com/newrelic/video-agent-roku/blob/master/components/NewRelicAgent/NRAgent.brs#L58

Even when we remove nodes with a player view, the player instance is still existing and the video is still "alive".

Could you add a function for example NewRelicVideoStop that will clear this reference so the video component will be destroyed properly?

bchelkowski commented 3 years ago

I added a PR with a proposal for the change.