search

newrelic / video-agent-roku

New Relic Agent for Roku
Apache License 2.0
18 stars 18 forks source link

Capture `Video.licenseStatus` #25

Closed timalacey closed 3 years ago

timalacey commented 3 years ago

This is an undocumented field that provides the DRM license response. I find it incredibly valuable to capture.

onLicenseStatusChanged() |video.licenseStatus=<Component: roAssociativeArray> =
{
    duration: 0
    keysystem: "Widevine"
    response: "{"code":130001,"message":"License denied. There were no valid internal or external entitlements for the user: [__anonymous]"}"
    status: 403
}
asllop commented 3 years ago

@timalacey since this is an undocumented feature, could you add a comment in the code to make it clear and explain the behavior? Also, would be amazing if you could update the README and add the attributes and events in the data model section. Same for #26.

Thanks!

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

timalacey commented 3 years ago

Thanks @asllop I've combined and updated.

timalacey commented 3 years ago

All checks now passed @asllop