search

newrelic / video-agent-roku

New Relic Agent for Roku
Apache License 2.0
18 stars 18 forks source link

Dashboard JSON No Longer Valid #33

Closed justinpage closed 3 years ago

justinpage commented 3 years ago

When downloading the latest available JSON from master:

https://raw.githubusercontent.com/newrelic/video-agent-roku/master/enablement/roku-dashboard.json

Results in New Relic not accepting it: Screen Shot 2021-08-14 at 5 27 27 PM

Looking at the JSON itself, I was able to remove the last property: "dashboard_account_id":xxxxx.

However, even when removing that entry, I was given the following error message on import:

Make sure you’re using the Dashboards Public API JSON Schema.

Looking at the following documentation: https://docs.newrelic.com/docs/apis/insights-apis/insights-dashboard-api/

We can see that New Relic's Schema has recently changed when compared to what is available in the master branch.

@adwetzelnr / @asllop: could one of you export the dashboard again, from New Relic, and update the latest copy here?

Really appreciate the help!

cjmccarthy commented 3 years ago

Hey @justinpage, thanks for catching this! The PR above should fix the issue, and as a bonus I've included a nice multi-page dashboard as well with some more advanced analytics. We'll merge the PR soon, but feel free to grab the JSON from the PR in the meantime.

justinpage commented 3 years ago

Thank you @cjmccarthy!