Closed vitalytarasov closed 2 years ago
@asllop & @cjmccarthy - any traction on this PR?
Hi, @vitalytarasov, sorry for the delay.
Your PR looks fine, with only a few objections:
UpdateConfig
doesn't follow the naming conventions. All methods start with "nr" (except the initializers and stoppers, that start with "NewRelic"). In your case, it should be nrUpdateConfig
.source/NewRelicAgent.brs
file. All our public methods have a wrapper in there, to avoid having to use callFunc
directly. The wrapper must also include documentation. Take the other definitions in the file as an example.@asllop - I have updated the PR to address your concerns.
This PR adds network proxy support as described in https://rokulikeahurricane.io/proxying_network_requests
App-level proxying
- this is the most common type of proxy for development of Roku channels. Default behavior is unchanged, proxy can be added usingUpdateConfig
method.