search

newrelic / video-agent-roku

New Relic Agent for Roku
Apache License 2.0
18 stars 18 forks source link

Agent is not unobserving previous video player node in NewRelicVideoStart #39

Closed georgejecook closed 2 years ago

georgejecook commented 2 years ago

in the sdk code, below, we can observe that there is never any unboserving/tidy up for previous video nodes. Not sure if that's gonna have any impact; but this isn't typically good practice. Many apps, have multiple video nodes over the course of a run, and I would have expected this to have been expected, in this function, and accordingly tidied up.

image

asllop commented 2 years ago

Hi @georgejecook ! To clean up when the video node is no longer used (or we don't want to track video events anymore on that video node), we provide the function NewRelicVideoStop:

https://github.com/newrelic/video-agent-roku/blob/6826d6210c6f230473868652f2b9ce0aaa6c4c47/components/NewRelicAgent/NRAgent.brs#L99

Is that what you expected?

asllop commented 2 years ago

Closing due to inactivity.