newrelic / video-agent-roku

New Relic Agent for Roku
Apache License 2.0
18 stars 18 forks source link

splashTime attribute is recorded as a String instead of a numeric #51

Closed cjmccarthy closed 1 year ago

cjmccarthy commented 1 year ago

splashTime attribute is recorded as a String instead of a numeric

asllop commented 1 year ago

@cjmccarthy the splashTime attribute comes directly from the associative array passed to Main when the channel starts, we copy it as is in the APP_STARTED event, and it is a string in the origin. This associative array contains multiple attributes, but unfortunately they are poorly documented, so there is no way to make sure what is the purpose, meaning, and standard format of splashTime. For this reason, a conversion of this attribute is risky, nowhere it says it will always be a number, the format could suddenly change in the next RokuOS release. The only available mentions of these attributes can be found here:

https://developer.roku.com/en-gb/docs/developer-program/discovery/implementing-deep-linking.md https://developer.roku.com/en-gb/docs/developer-program/getting-started/architecture/dev-environment.md