However, this is resulting in the app failing Roku Certification during static analysis:
------------------------------------------------------------------------------------------------------------------------
- Deprecated APIs -
------------------------------------------------------------------------------------------------------------------------
[WARNING] The GetVersion() API has been deprecated. Use the roDeviceInfo.GetOsVersion() function instead, which was introduced in Roku 9.2 OS, to get the major, minor, revision, and build numbers of the Roku OS running on a device.
Path: /components/vendor/newrelic/NRAgent.brs. Line: 1230. Documentation: https://developer.roku.com/docs/references/brightscript/interfaces/ifdeviceinfo.md#getosversion-as-object.
Happy to create a PR with this change, if the proposal is acceptable!
Note: I see similar issue was already proposed and closed in https://github.com/newrelic/video-agent-roku/issues/52; but this issue was raised to address the actual removal of GetVersion() rather than supporting it and GetOSVersion() simultaneously.
GetVersion()
API call is present in latest version (v8.2.1 as of today):https://github.com/newrelic/video-agent-roku/blob/master/components/NewRelicAgent/NRAgent.brs#L1230
However, this is resulting in the app failing Roku Certification during static analysis:
Please consider removing
GetVersion()
call altogether and raising minimum supported firmware from 8.2 (according to https://github.com/newrelic/video-agent-roku/blob/master/source/NewRelicAgent.brs#L4) to 9.2.Happy to create a PR with this change, if the proposal is acceptable!
Note: I see similar issue was already proposed and closed in https://github.com/newrelic/video-agent-roku/issues/52; but this issue was raised to address the actual removal of
GetVersion()
rather than supporting it andGetOSVersion()
simultaneously.