search

newrelic / video-agent-roku

New Relic Agent for Roku
Apache License 2.0
18 stars 18 forks source link

Flag-to-track-video-resume-as-CONTENT-START #69

Closed sathya-sundar closed 1 month ago

sathya-sundar commented 3 months ago

Issue Description: Our App has a feature to let user play content from a resume position. We noticed below issue in New Relic reporting when playback initiated using Resume button.

Given: User initiated payback using Resume CTA.

When: videoNode sent to New Relic has videoNode.position > 0

Then: CONTENT_START action not triggered.

Then: Our reports would miss all playbacks initiated through Resume CTA.

Fix: To fix the above issue, i have added a flag called m.nrShouldTrackResumeAsContentStart, which can be set by the App. If this flag is set to true, app will trigger CONTENT_START action even if videoNode.position > 0. If will only check if the state changed to playing after initial buffer to trigger the CONTENT_START action.

CLAassistant commented 3 months ago

CLA assistant check
All committers have signed the CLA.

asllop commented 1 month ago

We just release a new version (3.2.5) that should fix this issue.