search

newren / git-filter-repo

Quickly rewrite git repository history (filter-branch replacement)
Other
8.55k stars 708 forks source link

Fix path of git-filter-repo.(1|html) #333

Closed mattiasdrp closed 2 years ago

mattiasdrp commented 2 years ago

Since they are not at the root of the repo but in Documentation/(man1 | html) (the Makefile puts them here and the last releast tarball has them in it too)

mattiasdrp commented 2 years ago

Hi, No worries, we all have a lot of things to do :-) I fixed my commit to include the changes Thanks for this nice package

newren commented 2 years ago

Hi,

Thanks for understanding, and I'm glad you've enjoyed the package.

Thanks for fixing the wrapping and adding a Signed-off-by. It appears you've used a username rather than a real name, though. Is that right? As per https://github.com/git/git/blob/4fd6c5e44459e6444c2cd93383660134c95aabd1/Documentation/SubmittingPatches#L284-L286, I unfortunately need a real name for signoff. (And the author and committer should match the Signed-off-by as well.) Can you fix that?

mattiasdrp commented 2 years ago

I'm not very fond of letting my real name everywhere on the Internet. I don't mind you taking the ownership of this PR and merging it with your name though so ;-)

newren commented 2 years ago

Ok, thanks.