search

newren / git-filter-repo

Quickly rewrite git repository history (filter-branch replacement)
Other
8.52k stars 708 forks source link

Remove symlink that breaks install on Windows #455

Closed rdbisme closed 1 year ago

rdbisme commented 1 year ago

e.g. Using scoop

See: https://github.com/ScoopInstaller/Scoop/issues/4647:

Fix: #249

rdbisme commented 1 year ago

For context: on some unprivileged environments (where scoop is very useful), symlink cannot be created. Therefore, let's remove it from the source such that when scoop unzips the tarball, it doesn't complain about the privileges.

Another solution might be to exclude it from the release files (but couldn't find documentation about how Github builds the release files). Or create a windows specific release that replaces the symlink with a copy

rdbisme commented 1 year ago

Just removing the symlink to the python file should be good, because when publishing to PyPI, it gets created by the setup.py

newren commented 1 year ago

We should not rely on installation packages to add a symlink; it should be there in the original clone. Not to mention that I think that pip support and setup.py was a mistake, even if a well-intentioned one. Anyway, since you are relying on an installation package (namely from scoop) to get the package, they should be responsible to provide a working installation, including replacing the symlink with a copy. Feel free to file a bug with them.

See also issue #307

rdbisme commented 1 year ago

Never mind, you said you want the symlinks in the clone. :)