search

newren / git-filter-repo

Quickly rewrite git repository history (filter-branch replacement)
Other
8.55k stars 708 forks source link

Allow clean-ignore to run without arguments. #511

Closed CEBasile closed 4 months ago

CEBasile commented 1 year ago

clean-ignore is written to allow leverage of filter-repo to run additional operations on top of clean-ignore. If no arguments are specified nothing is passed to filter-repo and it errors out as it's expecting arguments. I chose "--force" based on previous comments from newren.

newren commented 4 months ago

Oh man, I'm such a bad maintainer. I apologize for taking so long to get back to you.

While investigating the issue behind 2800bcc1007e (clean-ignore: support utf-8 filenames found in .gitignore, 2024-07-02), I noticed the same issue and fixed it in a way compatible with how it was fixed for lint-history; see 5c54a5332b8e (clean-ignore: do not require additional arguments to be passed, 2024-07-02).

So, it's now fixed but differently. Sorry for not getting back to you sooner and suggesting you make the tweak. For future reference, it'd also be better to squash your commits into one (since these are not independent changes and the second just looks like a fixup of the first), and to wrap commit messages at 72 characters.

Anyway, I appreciate the contribution and feel bad for stepping on your toes.