search

newren / git-filter-repo

Quickly rewrite git repository history (filter-branch replacement)
Other
8.55k stars 708 forks source link

Dockerise the script #517

Closed nathanpovo closed 4 months ago

nathanpovo commented 1 year ago

Adds a docker file that can be used by people who do not have the python tooling installed locally (and do not want to install python just to use a script).

How to use

  1. Clone the repository locally (or just download the git-filter-repo and Dockerfile files)
  2. Build the docker image:
docker build . -t git-filter-repo
  1. Run the docker image:
docker run -it --rm -v $(pwd):/workdir git-filter-repo --help

For fellow powershell users: this has to be changed slightly to:

docker run -it --rm -v ${PWD}:/workdir git-filter-repo --help
  1. Follow the instructions of the script as normal
newren commented 4 months ago

The PR is certainly interesting, but I'm not particularly interested in adding yet-another-installation-method to the manual, and more importantly, in dealing with bug reports that the docker method doesn't allow them to run the contrib scripts and then needing to fix up the docker installation instructions to add those. So, I think I'm going to pass on this one.

But, I do appreciate the contribution and certainly see the idea as interesting, and am glad that if folks want to search for Docker in this repo they'll see your pull request. One heads up in case you submit other patches (since this one look like it's good quality just doesn't jive with what I want right now) -- for any contributions to this project, I need you to use a real email for author/committer/signoff; @users.noreply.github.com addresses won't cut it.

And sorry for the long delay in responding.

nathanpovo commented 4 months ago

Thank you for taking the time to respond and for maintaning such a good tool for git.

I'm not particularly interested in adding yet-another-installation-method to the manual, and more importantly, in dealing with bug reports that the docker method doesn't allow them to run the contrib scripts and then needing to fix up the docker installation instructions to add those. So, I think I'm going to pass on this one.

Understandable. This installation method was mainly for myself because I do not use python and did not want to go through the hassle of setting it all up. I do not wish to add yet more things for you to maintain for this project.

If I or anyone else needs this, they can simply search the repo for "Docker" and find this PR.

And sorry for the long delay in responding.

Not a problem.