search

newroco / emlviewer

nextcloud eml viewer plugin
GNU Affero General Public License v3.0
16 stars 3 forks source link

Composer detected issues in your platform: Your Composer dependencies require a PHP version ">= 8.0.0". #53

Closed piiskop closed 1 year ago

piiskop commented 1 year ago

i saw that there were update opportunities in the notifications and went there. EML Viewer was first on the list, Jitsi Integration was the second in the list. i clicked Update all. EML Viewer was updated and not the other two apps. Instead, i got this error message. Now, Nextcloud is not usable anymore. This instance is used by many people, so it cannot be down for long. How can i get Nextcloud working again?

putt1ck commented 1 year ago

You can disable apps via the command line using the occ tool. What version of Nextcloud are you running on what platform?

piiskop commented 1 year ago

Nextcloud Hub 3 (25.0.2)

kalmer@test:/etc/apache2/mods-enabled$ lsb_release -a

No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.5 LTS Release: 20.04 Codename: focal

Luticus commented 1 year ago

I got this too. Devs need to be a lot more careful with the dependencies I think. There are several mainstream Linux distros that are used heavily as servers for nextcloud but do NOT currently package php 8.0+ in their stable release repos. On top of this, Nextcloud still supports 7.4 for now. So imagine my surprise when I updated this one app and had it bring my entire Nextcloud instance down unexpectedly. Disabled for now, but sad because I like the app.

lucianpricop commented 1 year ago

I'm sorry about this mishap. Unfortunately I included the vendor folder produced on a machine running php8 even though composer does not require php8 for emlviewer. I removed the release archive so others can't install 1.0.5 and will prepare a new release ASAP.

Luticus commented 1 year ago

No worries, just took me by surprise is all :). I appreciate you fixing it up so quickly.

Really I think Nextcloud should ultimately have handled this situation better, if possible. I feel like apps shouldn't be able to bring down the instance like that, rather Nextcloud should refuse to load the app and simply continue working. Not sure what kind of engineering it might take to prevent such a thing from happening in the future, but maybe I'll report a bug to NC and see if they can take a look at it.

lucianpricop commented 1 year ago

I agree, there should be a mechanism to check if everything works well on your install and if not, just bring up an error that it couldn't update, so you'd still run NC and the old version of the app. A new release was published seconds ago, so should be fine with 1.0.6

piiskop commented 1 year ago

No worries, just took me by surprise is all :). I appreciate you fixing it up so quickly.

Really I think Nextcloud should ultimately have handled this situation better, if possible. I feel like apps shouldn't be able to bring down the instance like that, rather Nextcloud should refuse to load the app and simply continue working. Not sure what kind of engineering it might take to prevent such a thing from happening in the future, but maybe I'll report a bug to NC and see if they can take a look at it.

i reported there as well and got a quick response to report here although the main problem lies with them. they just do not want to be responsible for their own deficit. Another example is transparent icons for applications that they introduced lately without making sure that they would be visible with any background. Suddenly after the update, nobody could navigate as no link was visible. Again, they did not take the responsibility for that by mentioning how should they know what background a particular user has. Then the file app view is still jumping around and even new emails cannot be found in the mail app. i see a long list every time i update Nextcloud and cannot comprehend what all these updates really are for if essential things are still left untouched. Even for a major release.