search

news-catalyst / next-tinynewsdemo

Frontend for Tiny News Collective organizations
https://next-tinynewsdemo.vercel.app
1 stars 0 forks source link

Newsletter Archive page is publishing 'in review' newsletters #1283

Closed pdeharo333 closed 2 years ago

pdeharo333 commented 2 years ago

Tested a couple scenarios in staging with Letterhead. When a newsletter is in 'review' and you schedule a time/day you'd like it published, it publishes it on the archive page after deployment. But, when it's in 'draft' status it doesn't publish. This is where I'm looking to see why its picking up the newsletters in review and not just published.

Also to remove a newsletter from the archived page by deleting it in Hasura, you need to remove it in Letterhead first, otherwise it will not work.

pdeharo333 commented 2 years ago

https://github.com/news-catalyst/next-tinynewsdemo/pull/1286

pdeharo333 commented 2 years ago

Merged these changes into Main to test in staging site: PR 1 PR 2

To test:

  1. Go to Letterhead and create a published newsletter (when creating make sure to add the mailing block and unsubscribe link to be able to schedule and publish). You'll notice there is already newsletters for 'draft' 'review' and in 'schedule.'
  2. Redeploy staging in Vercel so it updates the Archive Newsletter Page
  3. You should notice that your newly published newsletter has been added to the archive page

While testing the welcome newsletter, I noticed it wasn't actually posting on folks archive page. In that previous example where we thought Nancy's welcome letter was posting it was actually a newsletter that she created as a welcome one. I also checked other orgs that have Welcome Letters BBG, Five Wards Media and confirmed this. So if you test and everything looks good this should be okay to push to Prod.

chelsea-tnc commented 2 years ago

Verified that welcome letters aren't being published. We reported an issue with the Letterhead API where sometimes welcome letters are included in the API response and sometimes they aren't. This is why we were seeing some welcome letters logged for some channels and not for others.