news-catalyst / next-tinynewsdemo

Frontend for Tiny News Collective organizations
https://next-tinynewsdemo.vercel.app
1 stars 0 forks source link

Fix: newsletter detail subscribe fix #1326

Closed angel-tnc closed 1 year ago

angel-tnc commented 1 year ago

Why

While testing secrets rotation, we realized the newsletter subscription block does not work in the newsletter article pages.

What

Added the missing site parameter the NewsletterBlock component.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
staging-tiny-news-sites ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 31, 2023 at 5:22PM (UTC)
2 Ignored Deployments | Name | Status | Preview | Comments | Updated | | :--- | :----- | :------ | :------- | :------ | | **tiny-news-curriculum** | ⬜️ Ignored ([Inspect](https://vercel.com/news-catalyst/tiny-news-curriculum/7CxNQcxA88KkpKvCFL14eWcDGpMQ)) | | | Mar 31, 2023 at 5:22PM (UTC) | | **tiny-news-sites** | ⬜️ Ignored ([Inspect](https://vercel.com/news-catalyst/tiny-news-sites/GhSuqwN3uWXm87HJZYjndWdZXYn1)) | | | Mar 31, 2023 at 5:22PM (UTC) |
chelsea-tnc commented 1 year ago

Good catch! Trying to get a better idea of the repro, here are the steps I tried:

  1. Go to a single newsletter page such as https://harveyworld.org/newsletters/the-2023-harvey-municipal-election/12632
  2. Scroll down to the very bottom and input name and email. Click submit. Is this the error fixed by this change? Screenshot 2023-04-03 at 6 48 27 PM
angel-tnc commented 1 year ago

Yep, the fix is for that "JSON input" error.