fix: Change cookies check to acknowledge value is a string

news-catalyst / next-tinynewsdemo

Frontend for Tiny News Collective organizations

https://next-tinynewsdemo.vercel.app

1 stars 0 forks source link

fix: Change cookies check to acknowledge value is a string #1335

Closed angel-tnc closed 1 year ago

angel-tnc commented 1 year ago

Why

It was discovered that the cookie accept / decline check does not respect when the user clicks "decline" because it assumes the value returned by getCookieConsentValue is a boolean, when it is actually a string.

What

Added a new function cookiesAccepted that calls getCookieConsentValue and returns a boolean, replaced used of the latter with the new function.

Fix for TNT-196

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
staging-tiny-news-sites	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 7, 2023 6:02pm

2 Ignored Deployments

pdeharo333 commented 1 year ago

Is the best way to test this to push to staging?