news-catalyst / next-tinynewsdemo

Frontend for Tiny News Collective organizations
https://next-tinynewsdemo.vercel.app
1 stars 0 forks source link

Remove Universal Analytics workflows #1339

Closed angel-tnc closed 1 year ago

angel-tnc commented 1 year ago

Why

Since we replaced the UA integration with GA4 and the reporting API used by these data imports is incompatible, these workflows will not be usable. We need to disable these data sync workflows .

Also, since we're not creating any new sites on TinyCMS, we can disable the bootstrap.js script.

What

Remove the Analytics data workflows and the bootstrap-test.js script. The bootstrap.js script was commented-out and a comment was added. This is to preserve it during transition, since it may be referenced in documentation or needed for reference or troubleshooting.

This PR addresses TNT-166

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [651437](https://dashboard.gitguardian.com/incidents/651437?occurrence=99441820) | Generic High Entropy Secret | 229998a1cfad62f31d29e22cceee31c0598c23f1 | script/bootstrap.js | [View secret](https://github.com/news-catalyst/next-tinynewsdemo/commit/229998a1cfad62f31d29e22cceee31c0598c23f1#diff-2756d5ef47837a4216037be163d89dec2ad29c69637e53cb6c174478bb123205L553) | | [651437](https://dashboard.gitguardian.com/incidents/651437?occurrence=99441821) | Generic High Entropy Secret | 229998a1cfad62f31d29e22cceee31c0598c23f1 | script/bootstrap.js | [View secret](https://github.com/news-catalyst/next-tinynewsdemo/commit/229998a1cfad62f31d29e22cceee31c0598c23f1#diff-2756d5ef47837a4216037be163d89dec2ad29c69637e53cb6c174478bb123205R556) | | [651437](https://dashboard.gitguardian.com/incidents/651437?occurrence=99441822) | Generic High Entropy Secret | 229998a1cfad62f31d29e22cceee31c0598c23f1 | script/bootstrap-tests.js | [View secret](https://github.com/news-catalyst/next-tinynewsdemo/commit/229998a1cfad62f31d29e22cceee31c0598c23f1#diff-396f18358bcf85a385b195b6b0aacf2b59585b629ae68587b58caecacba5dc26L95) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/generics/generic_high_entropy_secret#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
staging-tiny-news-sites ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 22, 2023 5:44pm
2 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **tiny-news-curriculum** | ⬜️ Ignored ([Inspect](https://vercel.com/news-catalyst/tiny-news-curriculum/5J7qLDBakh2S1F4jEcDTmJkoCp3X)) | | | Jun 22, 2023 5:44pm | | **tiny-news-sites** | ⬜️ Ignored ([Inspect](https://vercel.com/news-catalyst/tiny-news-sites/Mq8YCdkg6aWX3EQ7cwUrTntwAuwn)) | | | Jun 22, 2023 5:44pm |
swarmia[bot] commented 1 year ago

✅  Linked to Task TNT-166 · Decommission Google Analytics integration Github Workflows
➡️  Part of Epic TNT-15 · Move to GA4

pdeharo333 commented 1 year ago

Looks good, and I see your comment for the trackingID GA function.