Separate Transformers::Article into Scraper and Trainer

news-scraper / news_scraper

Simple ETL news scraper in Ruby

MIT License

4 stars 0 forks source link

Closed richardwu closed 8 years ago

richardwu commented 8 years ago

Key note:

Abstracted common methods (everything but constructor) into a Transformers::Article module
Created a Transformers::ScraperArticle and Transformers::TrainerArticle class

Would inheritance be better here?

cc: @jules2689

jules2689 commented 8 years ago

Inheritance probably makes sense, also you have merge conflicts

richardwu commented 8 years ago

re-ping

jules2689 commented 8 years ago

LGTM