news-scraper / news_scraper

Simple ETL news scraper in Ruby
MIT License
4 stars 0 forks source link

Trainer refactor into succinct, isolated flow, presets #7

Closed jules2689 closed 8 years ago

jules2689 commented 8 years ago

What this does

1) og_descriptions: example
2) I will provide a pattern using xpath
3) I will provide a pattern using css
4) skip
 if preset_results.empty?
            CLI.log("No presets were found for #{target_data_type}. Skipping to next.")

is actually not needed because it really just checks if data_type_presets is there and not empty... so now its private

jules2689 commented 8 years ago

@richardwu

richardwu commented 8 years ago

Besides a few nits, LGTM 👍

You could probably reduce the # of tests down with this refactor and have more end-to-end tests.

richardwu commented 8 years ago

Tests are beautiful 👌