newsboat / newsboat

An RSS/Atom feed reader for text terminals
https://newsboat.org/
MIT License
3k stars 215 forks source link

Any article deleted in search results remains after returning to article list #1330

Open emanruse opened 3 years ago

emanruse commented 3 years ago

Newsboat version (copy the output of newsboat -v or the first line of git show):

newsboat 2.21.0 - https://newsboat.org/
Copyright (C) 2006-2015 Andreas Krennmair
Copyright (C) 2015-2020 Alexander Batischev
Copyright (C) 2006-2017 Newsbeuter contributors
Copyright (C) 2017-2020 Newsboat contributors

Newsboat is free software licensed under the MIT License. (Type `newsboat -vv' to see the full text.)
It bundles:
- JSON for Modern C++ library, licensed under the MIT License: https://github.com/nlohmann/json
- optional-lite library, licensed under the Boost Software License: https://github.com/martinmoene/optional-lite
- expected-lite library, licensed under the Boost Software License: https://github.com/martinmoene/expected-lite

newsboat 2.21.0
System: Linux 5.9.8-2-default (i686)
Compiler: g++ 10.2.1 20200825 [revision c0746a1beb1ba073c7981eb09f55b3d993b32e5c]
ncurses: ncurses 6.2.20201031 (compiled with 6.2)
libcurl: libcurl/7.73.0 OpenSSL/1.1.1h-fips zlib/1.2.11 libidn2/2.3.0 libpsl/0.21.1 (+libidn2/2.3.0) libssh/0.9.5/openssl/zlib nghttp2/1.41.0 (compiled with 7.73.0)
SQLite: 3.33.0 (compiled with 3.33.0)
libxml2: compiled with 2.9.10

Config file (copy from ~/.newsboat/config or ~/.config/newsboat/config):

cleanup-on-quit yes
article-sort-order date asc
feed-sort-order firsttag
bind-key j down
bind-key k up
goto-next-feed no
articlelist-format "%f %D %?T?|%-17T| ?%t"
articlelist-title-format "%T (%u unread, %t total)"
itemview-title-format "'%T' (%u unread, %t total)"
feedlist-title-format "(%u unread, %t total)%?T? - tag ‘%T’&?"

Steps to reproduce the issue:

  1. Search for some string, e.g. press '/' and type it
  2. In search results press Shift+d to delete an unread article - 'D' shows up next to it
  3. Press 'q' to return to article list

Expected:

The article status should remain 'D' (deleted) after returning to the article list.

Actual:

The article status is simply unread but not deleted, so one has to delete it once again.

Minoru commented 3 years ago

Thanks for the report! I reproduced this with newsboat r2.21-271-g1428.

Previous report in Newsbeuter: https://github.com/akrennmair/newsbeuter/issues/121 Similar issue in Newsboat: https://github.com/newsboat/newsboat/issues/886

emanruse commented 3 years ago

It happens in "filtered view" of the article list too (when you define and apply a filter). Tested in 2.22.1.

emanruse commented 3 years ago

In filter view and search results view it seems also impossible to apply tags to an article.

Minoru commented 3 years ago

You mean flags? And by "impossible", you mean they are not preserved after you've quite the filter view/search results?

emanruse commented 3 years ago

Yes. Yes.

emanruse commented 2 years ago

This has been an issue since 2020 and still persists in 2.27.0. Would it be possible to somehow prioritize it?

Minoru commented 2 years ago

This is a volunteer-ran project, we don't do priorities, sorry. This will get fixed once someone decides to work on this.

emanruse commented 1 year ago

Update:

I just found something more.

STR:

  1. Do a search
  2. In the search result (article list) delete an article
  3. Go back to the feed the article belongs to - the article is there, seen as read
  4. Refresh the feed (from inside itself or from feed list, doesn't matter)

Result: the (previously deleted) article disappears.

IOW, the actual problem seems to be that articles deleted from search results (or query feeds) remain in some mid-state (cache?) and the UI still displays them, until the feed they belong to is refreshed.

I hope this will help to resolve the issue.