Closed jps closed 1 year ago
@GeriReid and @nathanparris Please have review on it http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/725-titlebar-storybook/storybook/?path=/docs/components-title-bar--story-title-bar-default
thanks @jannuk59.
On the examples without a heading could you please remove the extra padding above the title, so it sits centrally:
Logical Props - lowercase p in the heading please to read Logical props
Rest looks good, thanks :)
@nathanparris removed extra gap at the top of the title bar when we dont have heading. Please have a review at it http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/725-titlebar-storybook/storybook/?path=/docs/components-title-bar--story-title-bar
@jannuk59 Looks good to me
Thanks @nathanparris. Moving to peer review
Description
Updates to the Title bar component scenarios- Storybook
Tasks/Steps
Notes (main differences to what we have currently live versus the designs)
Acceptance/Testing Criteria
Given I am in Storybook When I view the Title bar component pages Then the pages will be updated as per the designs And the pages will be within 1024x768 for Applitools snapshots.
Business Benefit/Value
Consistent Title bar component examples for consumers, aligning to the NK branding.