newscorp-ghfb / NewsKit

The NewsKit Design system
https://newskit.co.uk
Other
130 stars 14 forks source link

Update Title bar component scenarios - Storybook #725

Closed jps closed 1 year ago

jps commented 1 year ago

Description

Updates to the Title bar component scenarios- Storybook

Tasks/Steps

Notes (main differences to what we have currently live versus the designs)

Acceptance/Testing Criteria

Given I am in Storybook When I view the Title bar component pages Then the pages will be updated as per the designs And the pages will be within 1024x768 for Applitools snapshots.

Business Benefit/Value

Consistent Title bar component examples for consumers, aligning to the NK branding.

jannuk59 commented 1 year ago

@GeriReid and @nathanparris Please have review on it http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/725-titlebar-storybook/storybook/?path=/docs/components-title-bar--story-title-bar-default

GeriReid commented 1 year ago

thanks @jannuk59.

Rest looks good, thanks :)

jannuk59 commented 1 year ago

@nathanparris removed extra gap at the top of the title bar when we dont have heading. Please have a review at it http://ncu-newskit-docs-pr.s3-website-eu-west-1.amazonaws.com/725-titlebar-storybook/storybook/?path=/docs/components-title-bar--story-title-bar

nathanparris commented 1 year ago

@jannuk59 Looks good to me

jannuk59 commented 1 year ago

Thanks @nathanparris. Moving to peer review