newscorp-ghfb / NewsKit

The NewsKit Design system
https://newskit.co.uk
Other
129 stars 13 forks source link

Update Tooltip component scenarios - Storybook #729

Closed jps closed 1 year ago

jps commented 1 year ago

Description

Updates to the Tooltip component scenarios- Storybook

Tasks/Steps

Using the designs update the storybook pages for the Tooltip component.

The designs include what should be on each page, and the title, description, and link to the documentation page on the site for the component.

Note the name of the pages also should be updated to match what we have in the designs.

Notes (main differences to what we have currently live versus the designs)

Acceptance/Testing Criteria

Given I am in Storybook

When I view the Tooltip component pages

Then the pages will be updated as per the designs

And the pages will be within 1024x768 for Applitools snapshots.

Business Benefit/Value

Consistent Tooltip component examples for consumers, aligning to the NK branding.

JohnTParsons commented 1 year ago

PR opened: https://github.com/newscorp-ghfb/NewsKit/pull/823

nathanparris commented 1 year ago

@JohnTParsons. Thanks updating. I have some feedback listed below:

General

Placements + visual tests

Variations

Controlled

Styling overrides

JohnTParsons commented 1 year ago

@nathanparris Changes pushed

nathanparris commented 1 year ago

@JohnTParsons Changes look good. Thanks.