newscorp-ghfb / NewsKit

The NewsKit Design system

https://newskit.co.uk

Other

130 stars 14 forks source link

Update Video player component interface & Storybook scenarios #730

Closed jps closed 1 year ago

jps commented 1 year ago

Description

Updates to the Video player component scenarios- Storybook

Tasks/Steps

Using the designs update the storybook pages for the Video Player component.
The designs include what should be on each page, and the title, description, and link to the documentation page on the site for the component.
Note the name of the pages also should be updated to match what we have in the designs.

Notes (main differences to what we have currently live versus the designs)

Default: removed variations - moved to own story
Placements and placements visual test - use what currently stands (screenshots below)
Variations: new story
Overrides: change colours and styles

Acceptance/Testing Criteria

Given I am in Storybook
When I view the Video Player component pages
Then the pages will be updated as per the designs
And the pages will be within 1024x768 for Applitools snapshots.

Business Benefit/Value

Consistent Video Player component examples for consumers, aligning to the NK branding.

JohnTParsons commented 1 year ago

PR is https://github.com/newscorp-ghfb/NewsKit/pull/830

@nathanparris ready for design review

nathanparris commented 1 year ago

@JohnTParsons Some feedback below:

Can you add a link to Brightcover player in the introduction text https://player.support.brightcove.com/getting-started/index.html (as shown in the design layout)
Styling overrides not matching design - I updated the play button example to a solid fill (was an icon change before)
There is an issue with the component defaults, where the title uses color the white token so this doesn't theme correctly in dark. Can this be updated to inkInverse.

JohnTParsons commented 1 year ago

Moving from Design Review to Peer Review